Fixes #2007 : Update objenesis dep to 3.2#2249
Merged
TimvdLippe merged 2 commits intoMar 31, 2021
Merged
Conversation
TimvdLippe
requested changes
Mar 31, 2021
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
We will also need to update android.gradle to use the latest version of objenesis again. E.g. we would need to effectively revert #2024 so that both android.gradle and the main project use the same version of objenesis.
…android (mockito#2024)" This reverts commit 626d457.
…ncompatibility
34d7eda to
e05fdd6
Compare
TimvdLippe
approved these changes
Mar 31, 2021
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
This LGTM! Just to confirm: have you locally applied these changes and ran your Android tests on SDK <26 and confirmed they are indeed running as expected? I would like to avoid publishing a breaking release once again.
Contributor
Author
|
Good call, just published the artifacts locally and gave it a go. Everything looks good, building and running tests on API 24! |
Contributor
|
Great, thanks for the confirmation! |
This was referenced Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for building android instrumentation tests with minsdk < 26
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant