Use single version for strictly in mockito-android#2053
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release/3.x #2053 +/- ##
==============================================
Coverage 84.90% 84.90%
Complexity 2704 2704
==============================================
Files 325 325
Lines 8206 8206
Branches 979 979
==============================================
Hits 6967 6967
Misses 968 968
Partials 271 271 Continue to review full report at Codecov.
|
TimvdLippe
approved these changes
Sep 24, 2020
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Thanks unfortunate, but understood why it doesn't work. Thanks for verifying and fixing!
This was referenced Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check list
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevantFixes #2007
In #2024, code review suggested to use
strictly '[2.6, 3.1['instead ifstrictly '2.6'. CommentApparently I failed to test that suggestion and it broke the fix in #2007.
Using
strictly '2.6'works as expected. It fails the objenesis resolution and suggest to exclude mockito-core from mockito-kotlin.