Merged
Conversation
Member
Author
|
cc/ @helje5 Please let me know if this ends up breaking anything for you 😅 |
c15d85d to
0db5f69
Compare
…the configuration's timeouts directly
0db5f69 to
6c91cd5
Compare
Contributor
|
This check is wrong: it should be |
Member
Author
Oops, let me fix and make a new tag. |
Member
Author
|
@helje5 Fixed in 0.2.1, sorry about that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated HTTP call to use a deadline set to the distant future to use the HTTP configuration's timeouts directly. This matches what APNSwift is doing, and observing the code in AsyncHTTPClient, seems to be what the NIO-based execution methods do as well when it is set to nil (though in that case, they skip adding a deadline task to cancel the request).