Correctly return NOERROR even if host resolver returned empty list#645
Merged
djs55 merged 1 commit intomoby:masterfrom Apr 1, 2025
Merged
Correctly return NOERROR even if host resolver returned empty list#645djs55 merged 1 commit intomoby:masterfrom
djs55 merged 1 commit intomoby:masterfrom
Conversation
7ea18b6 to
14556e2
Compare
Signed-off-by: dan0dbfe <2209822+dan0dbfe@users.noreply.github.com>
14556e2 to
427cb6d
Compare
Contributor
Author
|
The "usual" tests in |
|
What are the next steps on merging this fix? I'm happy to help if I can :) |
djs55
reviewed
Apr 1, 2025
| in | ||
| run ~pcap:"test_etc_hosts_priority.pcap" t | ||
|
|
||
| let test_noerror_empty_response server config () = |
Collaborator
There was a problem hiding this comment.
Thanks for adding test cases!
Collaborator
|
Thanks, builds and looks ok to me. I'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #509 and moby/moby#47628.
Dns.resolvenow returns(rr list, unit) resultto distinguish between[]resulting from NOERROR or NXDOMAIN.Dns.getaddrinforeturns(rr list, Msg) resultwith no error handling just like current behaviorMake.answerreturns answers (including[]) if there is no error, otherwise NXDOMAIN is returned.