Skip to content

Fix build with latest dune#642

Merged
djs55 merged 5 commits intomoby:masterfrom
avsm:fix-build
Aug 24, 2024
Merged

Fix build with latest dune#642
djs55 merged 5 commits intomoby:masterfrom
avsm:fix-build

Conversation

@avsm
Copy link
Copy Markdown
Collaborator

@avsm avsm commented Aug 24, 2024

This allows dune.3.16.0 to be installed, which in turn will allow testing the forthcoming dune package management feature in https://discuss.ocaml.org/t/ann-dune-developer-preview-updates/15160

@djs55
Copy link
Copy Markdown
Collaborator

djs55 commented Aug 24, 2024

CircleCI's license gather hit a few snags:

File "dune", lines 14-17, characters 0-127:
14 | (rule
15 |  (target licenses.json)
16 |  (deps deps.csv (:gen ./scripts/licenses.exe))
17 |  (action (run %{gen} -out %{target} -in %{deps})))
(cd _build/default && scripts/licenses.exe -out licenses.json -in deps.csv scripts/licenses.exe)
Fatal error: exception Failure("unknown licenses for dune-configurator.3.16.0, ctypes.0.23.0, csexp.1.5.2")

djs55 added 2 commits August 24, 2024 13:44
@djs55
more license updates
8951613 
Signed-off-by: David Scott <dave@recoil.org>
@djs55
dune-configurator.3.6.0 -> dune-configurator.3.16.0
c7672f7 
Signed-off-by: David Scott <dave@recoil.org>
djs55
djs55 approved these changes Aug 24, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@djs55 djs55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Licenses are good and "the usual" green CI is green, so LGTM

@djs55 djs55 merged commit 604ab7f into moby:master Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djs55 djs55 djs55 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avsm @djs55