Add version to package file and pin dependencies to fix build#641
Merged
djs55 merged 3 commits intomoby:masterfrom Aug 8, 2024
Merged
Add version to package file and pin dependencies to fix build#641djs55 merged 3 commits intomoby:masterfrom
djs55 merged 3 commits intomoby:masterfrom
Conversation
a3e4ca6 to
e996575
Compare
e996575 to
0fd8f17
Compare
Contributor
Author
|
So far, the build succeeds but the e2e tests fail |
Lots of minor updates to packages. Perhaps the version matching should be relaxed rather than requiring a manual update on every minor version? Signed-off-by: David Scott <dave@recoil.org>
…s codes It used to return 200, now it's a 301. It doesn't really matte for the purpose of the test. Signed-off-by: David Scott <dave@recoil.org>
djs55
approved these changes
Aug 8, 2024
Collaborator
djs55
left a comment
There was a problem hiding this comment.
Since the e2e tests work locally (although not in a container) and we don't care about appveyor (broken -- should be removed) and several of the ocaml-ci builds are expected to fail due to static linking issues on some distros I think we're good.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.