go: don't hold the metadata mutex and then acquire the channel mutex#626
Merged
djs55 merged 1 commit intomoby:masterfrom Mar 2, 2023
Merged
go: don't hold the metadata mutex and then acquire the channel mutex#626djs55 merged 1 commit intomoby:masterfrom
djs55 merged 1 commit intomoby:masterfrom
Conversation
Close() holds the channel mutex then calls decrChannelRef which acquires the metadata mutex. In DumpState() we should not hold the metadata mutex and then acquire the channel mutex. Signed-off-by: David Scott <dave@recoil.org>
mat007
approved these changes
Mar 2, 2023
|
|
||
| io.WriteString(w, "Active channels:\n") | ||
| for _, c := range channels { | ||
| io.WriteString(w, c.String()) |
Contributor
There was a problem hiding this comment.
I can see how having a mutex lock in channel.String may be unexpected. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close() holds the channel mutex then calls decrChannelRef which acquires the metadata mutex.
In DumpState() we should not hold the metadata mutex and then acquire the channel mutex.