Merged
Conversation
The code is clearer if each object only acquires its own mutex, and doesn't reach into the mutexes of others (if possible) Signed-off-by: David Scott <dave@recoil.org>
Previously we had a complicated set of channels and a condition variable, and the condition variable Wait() was in a goroutine. Instead the Wait() is now in the main goroutine and an optional timeout is in an optional goroutine. Signed-off-by: David Scott <dave@recoil.org>
If multiple calls are blocked waiting for window space, we need to use Broadcast() to wake them all up on a window update. Signed-off-by: David Scott <dave@recoil.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The net.Conn interface says:
Previously concurrent calls to
Write()would block for window space but only one would be woken up by aSignal()when a window update is received, allowing the other call to block forever.The handling of write timeouts was also confusing because
time.Sleepcouldn't be interruptedWait()was on a temporary goroutine