Ensure uname subprocess is cleaned up#593
Merged
djs55 merged 1 commit intomoby:masterfrom Aug 22, 2022
Merged
Conversation
Contributor
Author
|
Looks like CircleCI is using Xcode 12.0.0 which is no longer supported |
djs55
approved these changes
Aug 22, 2022
Collaborator
djs55
left a comment
There was a problem hiding this comment.
Thanks, the change looks fine to me. I'll investigate the CI.
I'm slightly surprised that this code ended up in the final binary. I think it is only supposed to be used at build-time. Maybe it needs to move out of src/bin?
Fixes moby#592 Signed-off-by: Terry Moschou <5567550+tmoschou@users.noreply.github.com>
8167090 to
827788c
Compare
Collaborator
|
I've taken the liberty of force-pushing a rebase after the recent CI improvements. |
Collaborator
|
OK, CI is a bit greener :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fix to the
unamecommand / subprocess spawned which was not cleaned up / reaped appropriately on Darwin.The result was a zombie process / resource leak that lingered in the process table.
Fixes #592