libproxy: ability to Close(), expose NewLoopback()#583
Merged
djs55 merged 3 commits intomoby:masterfrom Jun 9, 2022
Merged
Conversation
This is similar to calling Close() on a net.Listener to shut down the operation. Since this is an expected condition, don't log the debug ring in this case. Signed-off-by: David Scott <dave@recoil.org>
The NewLoopback() function returns a bidirectional buffered loopback connection which satisfies the interface of the multiplexer, which is convenient for tests which involve the multiplexer. Signed-off-by: David Scott <dave@recoil.org>
| } | ||
| } | ||
|
|
||
| var _ io.ReadWriteCloser = &loopback{} |
Collaborator
There was a problem hiding this comment.
👍 was looking for it in the main branch
fredericdalleau
approved these changes
Jun 9, 2022
Collaborator
fredericdalleau
left a comment
There was a problem hiding this comment.
LGTM. I don't see a test that closes the mux though.
Signed-off-by: David Scott <dave@recoil.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close()allows us to cleanly shutdown the multiplexer (similar toClose()on anet.Listener)NewLoopback()satisfies the interface of the multiplexer, which makes it easier to write test cases in downstream projects