libproxy: allow read/write buffers to be set#582
Merged
djs55 merged 2 commits intomoby:masterfrom Jun 9, 2022
Merged
Conversation
go/pkg/libproxy/multiplexed.go
Outdated
|
|
||
| // SetReadBuffer sets the size of the operating system's receive buffer associated with the connection. | ||
| // See similar function https://pkg.go.dev/net#IPConn.SetReadBuffer | ||
| func (c *channel) SetReadBuffer(bytes int) error { |
Collaborator
There was a problem hiding this comment.
The parameter should be unsigned. Otherwise if the user sets -1 here, it becomes havoc
Collaborator
There was a problem hiding this comment.
Ha I understand why it was int it can be setsockopt, it's bounded and can fail.
SO_RCVBUF
Sets or gets the maximum socket receive buffer in bytes.
The kernel doubles this value (to allow space for
bookkeeping overhead) when it is set using setsockopt(2),
and this doubled value is returned by getsockopt(2). The
default value is set by the
/proc/sys/net/core/rmem_default file, and the maximum
allowed value is set by the /proc/sys/net/core/rmem_max
file. The minimum (doubled) value for this option is 256.
boucane:~$ cat /proc/sys/net/core/rmem_max
212992
go/pkg/libproxy/multiplexed.go
Outdated
|
|
||
| // SetWriteBuffer sets the size of the operating system's write buffer associated with the connection. | ||
| // See similar function https://pkg.go.dev/net#IPConn.SetWriteBuffer | ||
| func (c *channel) SetWriteBuffer(bytes int) error { |
If the link has high latency then it's useful to use larger buffers Signed-off-by: David Scott <dave.scott@docker.com>
Signed-off-by: David Scott <dave@recoil.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the link has high latency then it's useful to use larger buffers
Signed-off-by: David Scott dave.scott@docker.com