Improve logs, demote some errors to warnings#575
Merged
djs55 merged 4 commits intomoby:masterfrom Apr 7, 2022
Merged
Conversation
Collaborator
djs55
commented
Apr 7, 2022
- use "HTTP proxy" rather than "transparent HTTP ..." because the proxy has both transparent and explicit/non-transparent modes
- demote some error logs to warnings, where it's the client misbehaving rather than us
The proxy supports both transparent and non-transparent proxying, the log lines were misleading. Signed-off-by: David Scott <dave@recoil.org>
We can receive malformed packets, it's not an error in our code so make it a warning instead. Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
These can happen if the client misbehaves, which is not an error in the proxy itself. Signed-off-by: David Scott <dave@recoil.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.