HTTP: add an optional allow list to the proxy#558
Merged
djs55 merged 9 commits intomoby:masterfrom Mar 2, 2022
Merged
Conversation
By default nothing changes. If an allow list is provided, the host must be on the list. Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Previously the Go code would alias the two cases together, so we add an explicit AllowEnabled boolean. Also allow the user to customize the error message if desired. Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
5d66c2f to
01f194f
Compare
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
This is the same format as used by moby/moby, see https://github.com/moby/moby/blob/master/cmd/dockerd/docker.go#L78 https://github.com/moby/moby/blob/7b9275c0da707b030e62c96b679a976f31f929d3/pkg/jsonmessage/jsonmessage.go#L17 Signed-off-by: David Scott <dave@recoil.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows an admin to set an allow list, such that requests for other domains / CIDRs / IPs will be blocked.
It re-uses the existing HTTP exclude matching functions.
There is still some work needed to distinguish the case
NoneandSome []in the .json configuration.