Don't calculate high_ip in DHCP configuration and zap outdated comment#556
Merged
djs55 merged 1 commit intomoby:masterfrom Apr 5, 2022
Merged
Don't calculate high_ip in DHCP configuration and zap outdated comment#556djs55 merged 1 commit intomoby:masterfrom
djs55 merged 1 commit intomoby:masterfrom
Conversation
This is a left over from when charrua would only work if there was a delta of at least one between min and max addresses. Also zap two outdated comments related to this issue. Signed-off-by: Christiano Haesbaert <haesbaert@haesbaert.org>
Collaborator
|
The CircleCI build for unrelated reasons (a pinned OCaml branch has been deleted -- I need to update it to a sha in the master branch) |
djs55
approved these changes
Jan 26, 2022
Collaborator
djs55
left a comment
There was a problem hiding this comment.
This makes sense and it's always good to actually resolve a FIXME!
LGTM
Collaborator
|
I'll fix CircleCI separately and then merge this. |
Collaborator
|
CircleCI is fixed on the master branch, I'll merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a left over from when charrua would only work if there was a delta of at
least one between min and max addresses.
Also zap two outdated comments related to the same issue.
I can't really test this code since I have no environment so please be careful.
Relevant commits
mirage/charrua@3c1995b
mirage/charrua@0bb4464