Skip to content

Update dependencies again, attempt to re-enable appveyor#552

Merged
djs55 merged 17 commits intomoby:masterfrom
djs55:ocaml-updates
Jan 21, 2022
Merged

Update dependencies again, attempt to re-enable appveyor#552
djs55 merged 17 commits intomoby:masterfrom
djs55:ocaml-updates

Conversation

@djs55
Copy link
Copy Markdown
Collaborator

@djs55 djs55 commented Jan 17, 2022

Update all the dependencies to latest, mostly minor changes:

  • Cstruct.len is renamed Cstruct.length
  • Fmt.strf is renamed Fmt.str
  • mirage-protocols has been deprecated in favour of using libraries directly (Tcpip, Arp), removing a layer of indirection

The most significant change is the removal of the ~listeners argument on the TCP input. This has been replaced with a listen and unlisten. Currently I've not added any calls to unlisten so it's probably leaking.

I've added an appveyor.yml based on mirage/mirage-block, to see if the CI build can be restored.

The minimum OCaml version needed by dependencies is now 4.08.

The remaining Windows package pins correspond to open PRs which I'd like to merge and release as soon as possible.

djs55 added 5 commits January 17, 2022 11:31
See mirage/mirage-tcpip#463

Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>

ethernet

Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
djs55 added 11 commits January 21, 2022 10:16
This has the potential to leak if the Hashtable keeps expanding.

It looks like a layer of callbacks can be removed, see the
`with_no_keepalives` function.

Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
The source branch has disappeared, let's use the master commit!

Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Previously they were lowercased but this isn't guaranteed.

Instead use the `get_multi` API to query the headers by key, leaving
cohttp to handle the case itself.

Also correct the order of arguments to alcotest: it's <expected> <actual>

Signed-off-by: David Scott <dave@recoil.org>
@djs55
Copy link
Copy Markdown
Collaborator Author

djs55 commented Jan 21, 2022

CI is green! Let's merge this to make master green too!

@djs55 djs55 merged commit 6dda85c into moby:master Jan 21, 2022
@djs55 djs55 deleted the ocaml-updates branch January 21, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant