Merged
Conversation
The new format looks like: ``` time="2021-04-17T10:56:51Z" level=info msg="usernet: Increasing preemptive thread pool size to 1024 threads" ``` Signed-off-by: David Scott <dave@recoil.org>
The other logging backends were not used. It's simpler to log to stderr and allow another program to capture the output (e.g. `docker logs`) Signed-off-by: David Scott <dave@recoil.org>
In several places we have a `log_exception_continue` function. Since we can continue, let's not log these as "errors" requiring developer attention. Signed-off-by: David Scott <dave@recoil.org>
There are 2 likely failures which we want to distinguish: 1. someone connected and disconnected to check if we are listening 2. a buggy client fails to negotiate the connection Rather than say ``` Pipe.listen: caught (Failure "Failed to connect vmnet device") ``` We say instead ``` Pipe.listen: rejected ethernet connection: EOF ``` Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Log as info instead. Signed-off-by: David Scott <dave@recoil.org>
Collaborator
Author
|
CircleCI is green! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we supported 3 log "destinations":
quiet: stderrasl: the Apple System Logeventlog: the Windows event logThis PR removes the
aslandeventlogsystems to simplify the build dependencies. Theeventlogmode was never used anywhere and I'm not sure if it's implemented correctly. Theaslmode is being used in Docker Desktop but this isn't a good idea: the system logs are difficult to filter and full of spam. It's much easier to simply log to stderr and rely on another tool to send the logs to the correct destination (e.g.docker logs)At the same time the output format has been changed to resemble other Go programs for consistency, e.g.:
Plus a few error logs have been downgraded to info where they are normal e.g.
/etc/resolv.confdoesn't exist on Windows; receivingEOFfrom a disconnecting client is normal.