Work around build failure in uri package#517
Merged
djs55 merged 1 commit intomoby:masterfrom Feb 9, 2021
Merged
Conversation
The failure looks like:
```
ocamlc lib/.uri.objs/byte/uri_re.{cmi,cmo,cmt} (exit 2)
(cd _build/default && /home/opam/.opam/4.07/bin/ocamlc.opt -w -40 -g -bin-annot -I lib/.uri.objs/byte -no-alias-deps -o lib/.uri.objs/byte/uri_re.cmo -c -impl lib/.wrapped_compat/Uri_re.ml-gen)
File "lib/.wrapped_compat/Uri_re.ml-gen", line 1, characters 99-110:
Error: Unbound module Uri__Uri_re
```
I suspect it's due to a missed dependency within the code itself, probably
due to the old packages and `dune`/`jbuilder` version. Building the package
separately seems to hide the problem, which is enough until we can upgrade
a lot of the dependencies.
Signed-off-by: David Scott <dave@recoil.org>
daa5a22 to
7f0eff0
Compare
Collaborator
Author
|
This seems to have fixed the build well enough for me to build and push this image: https://hub.docker.com/layers/djs55/vpnkit/7f0eff0dd99b576c5474de53b4454a157c642834/images/sha256-81b2b42c9be1c14882e762a1ff2c55e210e7786b3a9d4844dc06d38436af79f0?context=repo |
Collaborator
Author
|
Unfortunately the CI does not test the Dockerfile build :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure looks like:
I suspect it's due to a missed dependency within the code itself, probably due to the old packages and
dune/jbuilderversion. Building the package separately seems to hide the problem, which is enough until we can upgrade a lot of the dependencies.Signed-off-by: David Scott dave@recoil.org