go: switch to go.mod, Mac build fixes#514
Merged
djs55 merged 5 commits intomoby:masterfrom Apr 21, 2021
Merged
Conversation
Member
|
Looks like your git config doesn't match your sign-off; (DCO check can be picky with that) |
Collaborator
Author
|
@thaJeztah ah yes, I'd better fix that! |
Member
|
I should mention that you can manually mark it to "pass" if needed. Not sure if it supports a |
Contributor
|
lgtm |
$ go mod init $ go mod tidy Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
Also make kube-vpnkit-forwarder use the standard linuxkit pattern Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
This should hopefully make it easier to vendor this code elsewhere. Signed-off-by: David Scott <dave@recoil.org>
Collaborator
Author
|
OK I'm able to vendor this into another repo successfully 😅 ... the true test of Regarding CI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the go code is tested by CI on Linux, the Mac CI is currently broken and doesn't pick up failures in Mac-specific parts.