agent: Report ContainerStatus as part of TaskStatus.#571
agent: Report ContainerStatus as part of TaskStatus.#571aluzzardi merged 1 commit intomoby:masterfrom
Conversation
|
@stevvooe: Note that per our conversation earlier, |
|
@mrjana We're loosing the |
|
@aaronlehmann Hit #570 while playing with this |
c2e4edc to
46844d3
Compare
agent/exec/controller.go
Outdated
There was a problem hiding this comment.
Need a todo here to fix this interface.
With agent becoming part of engine, this should be possible to be saved as part of the engine container state. So that way we don't need to do some kind of hacky reverse-lookup from the spec in the manager. But we need that so that we have all the data for any api user to obtain name->hostPort mapping. |
agent/exec/container/controller.go
Outdated
There was a problem hiding this comment.
You could actually pre-allocate a slice by doing make([]*api.PortConfig, 0, len(portMap)) because we already know the size of the slice needed by this time, so that no reslicing happens when you are appending to the slice.
6d63ec6 to
960a37b
Compare
|
Rebased and added a few extras:
|
- Alter the controller to report container-specific task status - Added `Pid` and `ExitStatus` to `ContainerStatus` - Fill `ExposedPorts` in `ContainerStatus` - Misc changes so ContainerStatus finds its way to the dispatcher - CLI integration Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
960a37b to
5f5a2e3
Compare
|
Rebased ping @stevvooe |
|
LGTM |
1 similar comment
|
LGTM |
PidandExitStatustoContainerStatusExposedPortsinContainerStatusFor the sake of brevity, port mappings are reported in the same condensed mode as the Docker CLI does (also, note the Pid):
/cc @aaronlehmann @stevvooe @mrjana @vieux @tonistiigi