Merged
Conversation
api/types.proto
Outdated
Contributor
There was a problem hiding this comment.
Let's add ExitCode with this PR.
Member
Author
There was a problem hiding this comment.
You mean the field or the actual implementation? I'm not in favor of adding "broken" fields (as in, an ExitCode that will not be correctly set)
Related to #485 Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
f80d11a to
a95e093
Compare
Member
Author
|
Switched to oneofs. PTAL |
Contributor
|
LGTM |
Member
Author
|
@stevvooe You okay with merging this or do you want |
Contributor
|
@aluzzardi This is fine. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #485
/cc @mrjana @stevvooe @aaronlehmann