Dockerfile: set code dir as git safe directory#3115
Merged
thaJeztah merged 1 commit intomoby:masterfrom Feb 7, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3115 +/- ##
===========================================
+ Coverage 0 61.81% +61.81%
===========================================
Files 0 153 +153
Lines 0 31099 +31099
===========================================
+ Hits 0 19224 +19224
- Misses 0 10323 +10323
- Partials 0 1552 +1552 |
Member
|
Any idea why we need to set it here? (I recall I needed it somewhere in the past, but don't recall the details 🤔) |
Member
Author
|
@thaJeztah Wonder if this is linked to moby/moby#44929 (comment) so git fails. Will see if making it as safe directory solves the issue. Edit: Looks good as safe dir. |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
ebecdf4 to
9850df9
Compare
Member
|
Gonna bring this one in; CircleCI failure is unrelated, and we'll be removing it either way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #3114
https://github.com/moby/swarmkit/actions/runs/4090832788/jobs/7054522808#step:5:12
Looks to be the same issue as moby/moby#44930.
- What I did
Set code dir as git safe directory in the Dockerfile
- How I did it
- How to test it
- Description for the changelog