[19.03 backport] Fix leaking tasks.db#2940
Merged
dperny merged 1 commit intomoby:bump_v19.03from Apr 3, 2020
Merged
Conversation
For a long time, it's been a known fault that tasks.db grows out of control. The reason is that this database is only cleaned up, and old tasks removed, during initialization. When an assignment to a worker is removed, previously, the assignment was just marked as removed in the tasks database. However, an assignment is only removed from a worker when the task is removed from the manager. The worker does not need to continue to keep track of the task. Instead of marking a task as no longer assigned, when a task is removed as an assignment, we'll simply delete it from the database. I'm not 100% sure of what all the task database is responsible for, or why it needs to be persisted, so this change is targeted to have the minimal impact on the system. Signed-off-by: Drew Erny <derny@mirantis.com> (cherry picked from commit 585521d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@dperny @SamWhited @cpuguy83 ptal |
Collaborator
|
@thaJeztah merged. |
This was referenced Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #2938
For a long time, it's been a known fault that tasks.db grows out of
control. The reason is that this database is only cleaned up, and old
tasks removed, during initialization.
When an assignment to a worker is removed, previously, the assignment
was just marked as removed in the tasks database. However, an assignment
is only removed from a worker when the task is removed from the manager.
The worker does not need to continue to keep track of the task.
Instead of marking a task as no longer assigned, when a task is removed
as an assignment, we'll simply delete it from the database.
I'm not 100% sure of what all the task database is responsible for, or
why it needs to be persisted, so this change is targeted to have the
minimal impact on the system.
Signed-off-by: Drew Erny derny@mirantis.com
(cherry picked from commit 585521d)
Signed-off-by: Sebastiaan van Stijn github@gone.nl
- What I did
- How I did it
- How to test it
- Description for the changelog