Merged
Conversation
A previous change just a few commits before this accidentally introduced a proto field "Config" which was capitalizad. This lower-cases it, bringing it in line with the rest of the proto definitions. This would create an API incompatibility, but the errant revision has not shipped upstream yet, and so this change is acceptable. Signed-off-by: Drew Erny <drew.erny@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2813 +/- ##
=========================================
- Coverage 62.05% 61.9% -0.15%
=========================================
Files 137 137
Lines 22107 22144 +37
=========================================
- Hits 13718 13708 -10
- Misses 6912 6963 +51
+ Partials 1477 1473 -4 |
anshulpundir
approved these changes
Feb 1, 2019
This was referenced Feb 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous change (#2771) just a few commits before this accidentally introduced a proto field "Config" which was capitalizad. This lower-cases it, bringing it in line with the rest of the proto definitions. This would create an API incompatibility, but the errant revision has not shipped upstream yet, and so this change is acceptable.
Signed-off-by: Drew Erny drew.erny@docker.com