Closed
Conversation
Attempts to fix a bug in TestUpdaterRollback which is causing the test to fail in CI consistently. Signed-off-by: Drew Erny <drew.erny@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2728 +/- ##
=========================================
Coverage ? 62.28%
=========================================
Files ? 134
Lines ? 21787
Branches ? 0
=========================================
Hits ? 13570
Misses ? 6749
Partials ? 1468 |
Collaborator
Author
|
Interesting. Increasing the timeout fixes this test failure. |
anshulpundir
suggested changes
Aug 21, 2018
| assert.FailNow(t, "got EventUpdateTask when expecting EventCreateTask", fmt.Sprint(event)) | ||
| } | ||
| case <-time.After(time.Second): | ||
| case <-time.After(time.Second * 2): |
Contributor
There was a problem hiding this comment.
This increases the timeout for all tests. I don't think that's a good idea.
Contributor
|
@dperny btw I did same change already on #2762 which is merged so this one can be closed.
@anshulpundir yes it increased timeout for all tests but as root cause looks to be resource issue on CircleCI servers it is IMO correct way to fix these (I was able to prove that issue happens always if I set too tight CPU limit to docker run command). |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to fix a bug in TestUpdaterRollback which is causing the test to fail in CI consistently.
This PR is marked WIP as the failure only seems to occur in CI.