[docs] Document how raft encryption works#2622
Merged
cyli merged 1 commit intomoby:masterfrom May 17, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2622 +/- ##
=========================================
- Coverage 62.59% 61.9% -0.69%
=========================================
Files 51 134 +83
Lines 7180 21821 +14641
=========================================
+ Hits 4494 13508 +9014
- Misses 2231 6866 +4635
- Partials 455 1447 +992 |
Collaborator
|
LGTM! |
anshulpundir
approved these changes
May 7, 2018
Contributor
anshulpundir
left a comment
There was a problem hiding this comment.
Looks good, but I think rebase is needed ?
…dWriter and RaftDEKManager are abstracted from each other and their respective responsibilities. Signed-off-by: Ying Li <ying.li@docker.com>
Contributor
Author
|
Sorry for taking so long @anshulpundir to respond. Rebased, no conflicts, so merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular, why the
KeyReadWriterandRaftDEKManagerare abstracted from each other and their respective responsibilities.This is useful for reviewing #2586, and was cherry-picked from that PR.