Update design to describe desired state REMOVE behavior for tasks#2485
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2485 +/- ##
==========================================
+ Coverage 61.45% 61.52% +0.07%
==========================================
Files 129 129
Lines 21292 21292
==========================================
+ Hits 13084 13099 +15
+ Misses 6799 6778 -21
- Partials 1409 1415 +6 |
design/task_model.md
Outdated
| the `REJECTED` state if the agent rejected the | ||
| task, or the `ORPHANED` state if the node on which the task is scheduled is | ||
| down for too long. | ||
| down for too long. The orchestrator might also set desired state for a task to |
There was a problem hiding this comment.
The orchestrator might also set desired
Make this more certain e.g. the orchestrator will also set desired state for a task to 'REMOVE' for tasks not already in a terminal state.
design/task_model.md
Outdated
| down for too long. The orchestrator might also set desired state for a task to | ||
| `REMOVE` when the service associated with the task was removed or scaled down | ||
| by the user. When this happens, the agent proceeds to shut the task down. | ||
| The task is only fully removed by the task reaper when the shutdown succeeds. |
There was a problem hiding this comment.
fully removed => removed from the store
design/task_model.md
Outdated
| `REMOVE` when the service associated with the task was removed or scaled down | ||
| by the user. When this happens, the agent proceeds to shut the task down. | ||
| The task is only fully removed by the task reaper when the shutdown succeeds. | ||
| Notice that tasks that were removed becacuse of service removal or scale down |
There was a problem hiding this comment.
This line is probably redundant with the change above.
There was a problem hiding this comment.
I think it's useful to keep it here (also not sure why it's redundant).
There was a problem hiding this comment.
Redundant because of the line "The task is removed from the store by the task reaper only after the shutdown succeeds."
Removed from the store == not kept around in task history.
But its not a big deal.
There was a problem hiding this comment.
Gotcha. Still think it is useful to state explicitly for clarity.
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
2eb6a7e to
46ee581
Compare
|
@anshulpundir addressed your comments. |
Updating design docs based on new behavior introduced in #2461.
Ping @dperny @anshulpundir
Signed-off-by: Nishant Totla nishanttotla@gmail.com