Update logrus to v1.0.1 - with networkd, runc, containerd masters#2345
Merged
cyli merged 4 commits intomoby:masterfrom Aug 18, 2017
Merged
Update logrus to v1.0.1 - with networkd, runc, containerd masters#2345cyli merged 4 commits intomoby:masterfrom
cyli merged 4 commits intomoby:masterfrom
Conversation
Fixes case sensitivity issue Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2345 +/- ##
==========================================
+ Coverage 60.15% 60.36% +0.21%
==========================================
Files 128 128
Lines 26052 26052
==========================================
+ Hits 15671 15726 +55
+ Misses 8982 8936 -46
+ Partials 1399 1390 -9 |
Contributor
|
The containerd changed LGTM |
Member
Member
|
Updated versions look good to me, I suggest moving forward with this to avoid making it an even bigger headache |
Contributor
|
LGTM |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #2334 (thanks @dmcgowan), and implements @ijc instructions.
Not sure if the vendored version are completely correct though (I picked masters current heads)