[tests] No local signer for test CA if external CA is desired#2223
Merged
aaronlehmann merged 1 commit intomoby:masterfrom Jun 8, 2017
Merged
[tests] No local signer for test CA if external CA is desired#2223aaronlehmann merged 1 commit intomoby:masterfrom
aaronlehmann merged 1 commit intomoby:masterfrom
Conversation
…a local signer. Signed-off-by: Ying Li <ying.li@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2223 +/- ##
==========================================
- Coverage 60.27% 60.22% -0.05%
==========================================
Files 124 124
Lines 20149 20149
==========================================
- Hits 12145 12135 -10
- Misses 6639 6653 +14
+ Partials 1365 1361 -4 |
This was referenced Jun 8, 2017
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the test CA, if an external CA is desired, does not have a local signer.
Signed-off-by: Ying Li ying.li@docker.com
This also does is not a fix for #2221, but is more correct behavior. I added https://github.com/docker/swarmkit/pull/2210/files#diff-70b482ef8a125f8723ff2f77b65299faR146 as a comment and never followed through on it in #2210.