Temporarily vendor fork of etcd#2158
Merged
aaronlehmann merged 1 commit intomoby:masterfrom May 2, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2158 +/- ##
=========================================
+ Coverage 59.88% 59.9% +0.01%
=========================================
Files 119 119
Lines 19664 19664
=========================================
+ Hits 11776 11779 +3
+ Misses 6550 6545 -5
- Partials 1338 1340 +2 |
nishanttotla
reviewed
May 1, 2017
vendor.conf
Outdated
|
|
||
| # etcd/raft | ||
| github.com/coreos/etcd 824277cb3a577a0e8c829ca9ec557b973fe06d20 | ||
| github.com/coreos/etcd ea5389a79f40206170582c1ea076191b8622cb8e https://github.com/aaronlehmann/etcd |
Contributor
There was a problem hiding this comment.
nit: does it make sense to link to the specific etcd PR here, so that it's clear why this fork was needed?
Now that we are using CheckQuorum, it is causing some spurious leader elections that are leading to test failures in both SwarmKit and Docker integration tests. I submitted this change upstream, but it hasn't been reviewed yet. I'd like to temporarily vendor a fork that has the change. First, this will unblock vendoring swarmkit from the master branch. Also, it will give us a chance to test the change more broadly. Finally, we probably don't want to vendor the master branch of etcd, so without this temporary fork, we'd have to wait for a release that includes this change. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
5608568 to
5d77af7
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are using CheckQuorum, it is causing some spurious leader
elections that are leading to test failures in both SwarmKit and Docker
integration tests.
I submitted this change upstream, but it hasn't been reviewed yet. I'd
like to temporarily vendor a fork that has the change. First, this will
unblock vendoring swarmkit from the master branch. Also, it will give us
a chance to test the change more broadly. Finally, we probably don't
want to vendor the master branch of etcd, so without this temporary
fork, we'd have to wait for a release that includes this change.