Skip to content

Rename storeapi to watchapi#2102

Merged
dongluochen merged 2 commits intomoby:masterfrom
dongluochen:watch_service
May 2, 2017
Merged

Rename storeapi to watchapi#2102
dongluochen merged 2 commits intomoby:masterfrom
dongluochen:watch_service

Conversation

@dongluochen
Copy link
Copy Markdown
Contributor

Replace #2099.

The second commit changes watchapi to monitor local store instead of leader.

@dongluochen
Copy link
Copy Markdown
Contributor Author

Don't know why it fails CI. Do I miss something?

dchen@vm2:~/go/src/github.com/docker/swarmkit$ make checkprotos
🐳 bin/protoc-gen-gogoswarm
🐳 generate
protoc -I.:../protobuf:../vendor:../vendor/github.com/gogo/protobuf --gogoswarm_out=plugins=grpc+deepcopy+storeobject+raftproxy+authenticatedwrapper,import_path=github.com/docker/swarmkit/api,Mgogoproto/gogo.proto=github.com/gogo/protobuf/gogoproto,Mgoogle/protobuf/descriptor.proto=github.com/gogo/protobuf/protoc-gen-gogo/descriptor,Mplugin/plugin.proto=github.com/docker/swarmkit/protobuf/plugin,Mgoogle/protobuf/duration.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/any.proto=github.com/gogo/protobuf/types:. types.proto specs.proto objects.proto control.proto dispatcher.proto ca.proto snapshot.proto raft.proto health.proto resource.proto logbroker.proto watch.proto
protoc -I.:/usr/local --gogoswarm_out=import_path=github.com/docker/swarmkit/protobuf/plugin,Mgoogle/protobuf/descriptor.proto=github.com/gogo/protobuf/protoc-gen-gogo/descriptor:. plugin.proto
protoc -I.:../../../../vendor --gogoswarm_out=plugins=deepcopy,import_path=github.com/docker/swarmkit/protobuf/plugin/deepcopy/test:. deepcopy.proto
protoc -I.:../../../../vendor --gogoswarm_out=plugins=grpc+raftproxy,import_path=github.com/docker/swarmkit/protobuf/plugin/raftproxy/test:. service.proto
🐳 checkprotos
dchen@vm2:~/go/src/github.com/docker/swarmkit$ go version
go version go1.7.5 linux/amd64
dchen@vm2:~/go/src/github.com/docker/swarmkit$ git diff
dchen@vm2:~/go/src/github.com/docker/swarmkit$ git status
On branch watch_service
nothing to commit, working directory clean

@aaronlehmann
Copy link
Copy Markdown
Collaborator

You need to upgrade protoc

Signed-off-by: Dong Chen <dongluo.chen@docker.com>
Signed-off-by: Dong Chen <dongluo.chen@docker.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2017

Codecov Report

Merging #2102 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2102      +/-   ##
==========================================
+ Coverage   59.23%   59.28%   +0.04%     
==========================================
  Files         117      117              
  Lines       19361    19360       -1     
==========================================
+ Hits        11468    11477       +9     
+ Misses       6563     6558       -5     
+ Partials     1330     1325       -5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d7fb2...a6e08a0. Read the comment docs.

@aaronlehmann
Copy link
Copy Markdown
Collaborator

LGTM

@dongluochen
Copy link
Copy Markdown
Contributor Author

Ping @aluzzardi.

@aaronlehmann
Copy link
Copy Markdown
Collaborator

ping @aluzzardi

@aluzzardi
Copy link
Copy Markdown
Member

LGTM

@dongluochen dongluochen merged commit 638f579 into moby:master May 2, 2017
@dongluochen dongluochen deleted the watch_service branch May 2, 2017 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants