Merged
Conversation
Contributor
Author
|
Don't know why it fails CI. Do I miss something? |
Collaborator
|
You need to upgrade protoc |
Signed-off-by: Dong Chen <dongluo.chen@docker.com>
Signed-off-by: Dong Chen <dongluo.chen@docker.com>
5d2908c to
a6e08a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2102 +/- ##
==========================================
+ Coverage 59.23% 59.28% +0.04%
==========================================
Files 117 117
Lines 19361 19360 -1
==========================================
+ Hits 11468 11477 +9
+ Misses 6563 6558 -5
+ Partials 1330 1325 -5Continue to review full report at Codecov.
|
Collaborator
|
LGTM |
Contributor
Author
|
Ping @aluzzardi. |
Collaborator
|
ping @aluzzardi |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace #2099.
The second commit changes watchapi to monitor local store instead of leader.