Codecov Report

Merging #1969 into master will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1969      +/-   ##
==========================================
+ Coverage   53.47%   53.62%   +0.15%     
==========================================
  Files         109      109              
  Lines       18919    18919              
==========================================
+ Hits        10116    10146      +30     
+ Misses       7570     7533      -37     
- Partials     1233     1240       +7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6e3d3...1894c42. Read the comment docs.

probably it is better to change package name as well

@AkihiroSuda I knew there would be something I missed ;-). I'm a bit surprised it even built...

A quick sed on the package lines opened up the sorts of errors I'd have expected (and should have been more suspicious of the absence of):

cmd/swarmd/main.go:14: imported and not used: "github.com/docker/swarmkit/agent/exec/dockerapi"
cmd/swarmd/main.go:154: undefined: container in container.NewExecutor

I also came to share these sentiments https://github.com/docker/swarmkit/blob/master/agent/exec/container/controller_test.go#L28...

Anyway, fixed.

LGTM

LGTM

Looks like there is a rebase required.

Rebased. Seeing as how this is a bulk rename it will likely conflict with any PR which touches agent/exec/container (at least the rebase is trivial), perhaps we should coordinate a time for a quick rebase + push + merge turnaround if this one doesn't survive long enough to get merged.