Add indices over tasks and services by referenced network and secret IDs#1728
Add indices over tasks and services by referenced network and secret IDs#1728aluzzardi merged 2 commits intomoby:masterfrom
Conversation
f02ee45 to
d982331
Compare
| github.com/google/certificate-transparency 0f6e3d1d1ba4d03fdaab7cd716f36255c2e48341 | ||
| github.com/hashicorp/go-immutable-radix 8e8ed81f8f0bf1bdd829593fdd5c29922c1ea990 | ||
| github.com/hashicorp/go-memdb 98f52f52d7a476958fa9da671354d270c50661a7 | ||
| github.com/hashicorp/go-memdb 608dda3b1410a73eaf3ac8b517c9ae7ebab6aa87 https://github.com/floridoo/go-memdb |
There was a problem hiding this comment.
Do you think we should fork the fork and rebase?
Is our vendored version newer than the fork (e.g. are we removing fixes from master)?
There was a problem hiding this comment.
Our vendored version is a few days newer, but I checked and the only changes that the fork misses are new features that we don't use. There are no missing bugfixes.
Previously, it was not possible to have indices which could have more than one value per object. This vendors a fork of go-memdb that adds this feature, from a PR that has been pending for more than eight months. It then adds indices over tasks and services for the network and secret IDs referenced by the tasks and services. Network deletion is updated to use the new index instead of listing all services. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
d982331 to
cd5d800
Compare
Current coverage is 55.92% (diff: 49.53%)@@ master #1728 diff @@
==========================================
Files 96 96
Lines 14922 15005 +83
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 8353 8391 +38
- Misses 5464 5494 +30
- Partials 1105 1120 +15
|
|
Thanks @aaronlehmann would you mind including the fix for #1724 here instead ? I can close #1724 given including it here will be a better fix ? |
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
|
@mavenugo: I added a commit to do this. It involved a few changes to the orchestrator since I found some cases where we could create a task after the service had been deleted. |
|
LGTM Thanks for doing this! |
|
👍 thanks @aaronlehmann. I will close #1724 now. |
|
LGTM |
Previously, it was not possible to have indices which could have more
than one value per object. This vendors a fork of go-memdb that adds
this feature, from a PR that has been pending for more than eight
months. It then adds indices over tasks and services for the network and
secret IDs referenced by the tasks and services. Network deletion is
updated to use the new index instead of listing all services.
cc @aluzzardi @mrjana @diogomonica @mavenugo