Skip to content

Fixed bug in secrets assignment, added logging#1697

Merged
aaronlehmann merged 1 commit intomoby:masterfrom
diogomonica:fixing-secret-assignment-bug
Oct 27, 2016
Merged

Fixed bug in secrets assignment, added logging#1697
aaronlehmann merged 1 commit intomoby:masterfrom
diogomonica:fixing-secret-assignment-bug

Conversation

@diogomonica
Copy link
Contributor

@diogomonica diogomonica commented Oct 26, 2016

  • Fixes a secret assignment bug
  • Fixes swarmctl to add SecretID to the SecretReferences
  • Adds a validation that all secret references have a name and an ID
  • Adds simple logging to the secrets control api

Signed-off-by: Diogo Monica diogo.monica@gmail.com

@diogomonica
Copy link
Contributor Author

diogomonica commented Oct 26, 2016

/cc @aaronlehmann @ehazlett

@aaronlehmann
Copy link
Collaborator

aaronlehmann commented Oct 26, 2016

Unit test failure

--- FAIL: TestAssignmentsInitialNodeTasks (0.47s)
    Error Trace:    dispatcher_test.go:414
    Error:      Not equal: 5 (expected)
                    != 6 (actual)

@ehazlett
Copy link
Contributor

ehazlett commented Oct 26, 2016

assignment fix LGTM (not a maintainer)

@ehazlett ehazlett mentioned this pull request Oct 26, 2016
Merged
4 tasks
@stevvooe
Copy link
Contributor

stevvooe commented Oct 26, 2016

What is the bug?

@thaJeztah thaJeztah added this to the 1.13.0 milestone Oct 27, 2016
@thaJeztah
Copy link
Member

thaJeztah commented Oct 27, 2016

/cc @aluzzardi @aaronlehmann

@stevvooe
Copy link
Contributor

stevvooe commented Oct 27, 2016

LGTM

@aaronlehmann
Copy link
Collaborator

aaronlehmann commented Oct 27, 2016

Not LGTM

The tests still don't pass.

@diogomonica diogomonica force-pushed the fixing-secret-assignment-bug branch from 6edf9d5 to b14816d Compare October 27, 2016 22:57
@diogomonica
Fixed bug in secrets assignment, added logging
596ad76 
Signed-off-by: Diogo Monica <diogo.monica@gmail.com>
@diogomonica diogomonica force-pushed the fixing-secret-assignment-bug branch from b14816d to 596ad76 Compare October 27, 2016 23:06
@codecov-io
Copy link

codecov-io commented Oct 27, 2016 •
edited
Loading

Current coverage is 56.23% (diff: 67.74%)

Merging #1697 into master will increase coverage by 0.65%

@@             master      #1697   diff @@
==========================================
  Files            89         90     +1   
  Lines         14606      14540    -66   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           8117       8176    +59   
+ Misses         5418       5278   -140   
- Partials       1071       1086    +15

Sunburst

Powered by Codecov. Last update 8148920...596ad76

@thaJeztah
Copy link
Member

thaJeztah commented Oct 27, 2016

it's 💚 now

@aaronlehmann
Copy link
Collaborator

aaronlehmann commented Oct 27, 2016

LGTM

@aaronlehmann aaronlehmann merged commit 4f28a49 into moby:master Oct 27, 2016
@diogomonica diogomonica deleted the fixing-secret-assignment-bug branch October 28, 2016 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

priority/P0 status/2-code-review

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

7 participants

@diogomonica @aaronlehmann @ehazlett @stevvooe @thaJeztah @codecov-io @GordonTheTurtle