Personally I don't think this hack belongs here.

Just make this a ListenLocal function that isn't passed a protocol. The windows version should use winio.ListenPipe and the unix version should use Listen("unix", addr).

For now the manager can special-case "unix" as needing a call to ListenLocal, but I think we should immediately refactor the manager to remove the ProtoAddr map so the hack isn't necessary.

I agree that this should be done, but then it leads itself right into unrolling that loop and doing a big refactor of the listening code, which is a headache all of its own. I'd say anything more than a straight API substitution is out of scope.

I think that loop could be easily unrolled - right now most of the content is unix specific anyway and the tcp side is pretty straightforward:

if _, ok := config.ProtoListener["unix"]; !ok {
  l, err := xnet.ListenLocal(config.ProtoAddr["unix"])
  ...
  // No need for proto == "unix"
  if unwrappedErr == syscall.EADDRINUSE {
  }
  ...  
}

if _, ok := config.ProtoListener["tcp"]; !ok {
  // Note no need to use xnet here
  ... := net.Listen("tcp", config.ProtoAddr["unix"])
  // No need for weird if proto == "tcp"
  tcpAddr = l.Addr().String()  
}

Thoughts?

I think that loop can be just unrolled to two if and we don't have to mess with proto == [tcp|unix] in the loop, just add the statements

To @dperny's point - I don't know if that should be done in a separate PR to keep the scope of this one simple.

Do we need MkdirAll for npipes?

oohhhhh that's not good. that's wrong. that should be GOOS == "windows"

no it definitely is supposed to be GOOS != "windows". if the OS is not windows we create a directory. we don't need to make a directory for windows named pipes; they exist in their own, like, space.