Add --cap-add as and --cap-drop to swarm services#1565
Closed
alex-berger wants to merge 1 commit intomoby:masterfrom
alex-berger:add-capabilities-support-for-services
Closed
Add --cap-add as and --cap-drop to swarm services#1565alex-berger wants to merge 1 commit intomoby:masterfrom alex-berger:add-capabilities-support-for-services
alex-berger wants to merge 1 commit intomoby:masterfrom
alex-berger:add-capabilities-support-for-services
Conversation
Fixes moby/moby#25885 Having this in place we can now use capabilities in the following CLI calls respectively in the corresponding API calls. - service create - service update Signed-off-by: Alexander Berger <alex-berger@gmx.ch>
Author
|
This PR is required for moby/moby#26849. |
Current coverage is 54.08% (diff: 100%)@@ master #1565 diff @@
==========================================
Files 79 82 +3
Lines 13479 13607 +128
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7276 7360 +84
- Misses 5219 5246 +27
- Partials 984 1001 +17
|
Contributor
|
As per review on Docker PR I don't think we should do this. |
Contributor
|
@justincormack @alex-berger should we close this PR? |
Member
|
Hey, thanks a lot @alex-berger. We want to be able to support adding capabilities. Right now we're stuck because of portability - there's many commands supported by Will keep you posted but we do appreciate the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes moby/moby#25885
Having this in place we can now use capabilities in the following CLI calls respectively in the corresponding API calls.
Signed-off-by: Alexander Berger alex-berger@gmx.ch