Skip to content

Remove unused websocket package#98

Merged
dims merged 1 commit into
moby:masterfrom
dmcgowan:remove-ws-package
Jun 27, 2024
Merged

Remove unused websocket package#98
dims merged 1 commit into
moby:masterfrom
dmcgowan:remove-ws-package

Conversation

@dmcgowan

Copy link
Copy Markdown
Member

This package serves no purpose and is not imported anywhere https://pkg.go.dev/github.com/moby/spdystream/ws. Remove this to cleanup unnecessary go.sum entries.

Signed-off-by: Derek McGowan <derek@mcg.dev>

@dims dims left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aojea

aojea commented Jun 27, 2024

Copy link
Copy Markdown

LGTM

@thaJeztah

Copy link
Copy Markdown
Member

cc @adisky (if we need another maintainer review, but I'm fine with merging this after the folks above have reviewed it)

@dims dims left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims dims merged commit 258380d into moby:master Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants