don't resolve endpoint hostnames DNS#9728
Closed
kdomanski wants to merge 3 commits intomoby:masterfrom
kdomanski:repo_lookup
Closed
don't resolve endpoint hostnames DNS#9728kdomanski wants to merge 3 commits intomoby:masterfrom kdomanski:repo_lookup
kdomanski wants to merge 3 commits intomoby:masterfrom
kdomanski:repo_lookup
Conversation
Signed-off-by: Kamil Domański <kamil@domanski.co> (github: kdomanski)
Signed-off-by: Kamil Domański <kamil@domanski.co> (github: kdomanski)
Signed-off-by: Kamil Domański <kamil@domanski.co> (github: kdomanski)
Contributor
Author
|
ping @tiborvass |
Contributor
|
Like I told @kdomanski via chat, I understand the urge to solve the issue, but this will break other people who rely on the CIDR feature, so I'm closing this PR. I have a better alternative coming soon. Thanks for looking into this @kdomanski and for helping me figure it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #9708 . The tradeoff is, DNS resolution can no longer be used to match against insecure registries list. As a consequence, 127.0.0.1 is still automatically insecure, but localhost is not anymore.
Hostnames can still be matched verbatim against other hostnames.