Replacing -d/--daemon with daemon command. Implementation of 'docker daemon' command#9255
Replacing -d/--daemon with daemon command. Implementation of 'docker daemon' command#9255shishir-a412ed wants to merge 2 commits intomoby:masterfrom
Conversation
|
There seems to be something work with your PR considering the amount of commits and diffs it introduces (bad rebase perhaps?). Could you please fix it so we can pursue with implementation review? Ping @shykes and add label UX. |
…daemon' command QE Reports that you can put lots of bogus options on the cli before the command which are ignored if you specify a command. We should report a usage error if a user does this. I believe a better long term solution would be to remove the -d options and add a daemon command. This would make the handling of options the same for all use cases. Docker-DCO-1.1-Signed-off-by: Dan Walsh dwalsh@redhat.com (github: rhatdan) Docker-DCO-1.1-Signed-off-by: Shishir Mahajan shishir.mahajan@redhat.com (github: shishir-a412ed)
8bebad7 to
cec62f6
Compare
|
@icecrime I have rebased the commit. |
|
Thanks, there still are a few things wrong with the PR in itself: the DCO is wrong (missing But before getting into these details: @crosbymichael WDYT? I think it's interesting, but we shouldn't waste more contributors time if we have no intention to merge (avoiding another #6055). |
|
It's a bit frustrating to be able to run (Edit: this is support of this PR) |
|
I'm still in favor of this; it makes it much clearer which flags are meant for the daemon, and the output of help/usage on the command line will be a lot less messy. |
|
Docs LGTM, though I presume they might be a little out of date |
|
Should |
|
Closing this one. |
Following up on PR #6055 which was initiated by Dan Walsh (rhatdan).