Skip to content

migrate TestContainerAPIPostContainerStop to integration#51865

Merged
thaJeztah merged 1 commit intomoby:masterfrom
yudnk:50159-migrate_test_container_api_post_container_stop
Jan 21, 2026
Merged

migrate TestContainerAPIPostContainerStop to integration#51865
thaJeztah merged 1 commit intomoby:masterfrom
yudnk:50159-migrate_test_container_api_post_container_stop

Conversation

@yudnk
Copy link
Contributor

@yudnk yudnk commented Jan 17, 2026

- What I did

I migrated TestContainerAPIPostContainerStop to integration tests.
Relates to #50159

- How I did it

  • Migrated TestContainerAPIPostContainerStop to integration/container/stop_test.go from integration-cli/docker_api_containers_test.go.
  • Changed from apiClient calls to direct HTTP requests because,
    • apiClient usage is already covered in other test. (e.g. TestContainerAPIStop)
    • the test targets the route handler behavior, as indicated by its name.
  • Added subtests for scenarios where the container is already stopped and where the container does not exist.

- How to verify it

Verified running the integration test with following command.
TEST_FILTER='TestContainerAPIPostContainerStop' TEST_SKIP_INTEGRATION_CLI=1 make test-integration

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Migrates:

- TestContainerAPIPostContainerStop

Signed-off-by: Yudai Nakakubo <nyggl4dev@gmail.com>
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Jan 20, 2026
@thaJeztah thaJeztah added this to the 29.2.0 milestone Jan 20, 2026
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit f23e824 into moby:master Jan 21, 2026
291 of 293 checks passed
@thaJeztah
Copy link
Member

Thanks!

@yudnk yudnk deleted the 50159-migrate_test_container_api_post_container_stop branch January 22, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants