integration/container: migrate stream connected containers test#51840
Open
deahtstroke wants to merge 1 commit intomoby:masterfrom
Open
integration/container: migrate stream connected containers test#51840deahtstroke wants to merge 1 commit intomoby:masterfrom
deahtstroke wants to merge 1 commit intomoby:masterfrom
Conversation
deahtstroke
commented
Jan 21, 2026
| } | ||
|
|
||
| func (s *DockerAPISuite) TestAPIStatsNoStreamConnectedContainers(c *testing.T) { | ||
| testRequires(c, DaemonIsLinux) |
Author
There was a problem hiding this comment.
I forgot to add the this requirement to the migrated test.
Member
There was a problem hiding this comment.
Ah! I overlooked that as well 😅 - I gave CI a kick to run again; let's see if it goes green 🤞
234c2be to
eea1a2b
Compare
Author
|
The latest update just updates the context timeout from 10s => 20s. It's just a hunch but I want to see if the error is related to a timeout perhaps? |
e6100a2 to
d87850f
Compare
Signed-off-by: Daniel Villavicencio <dvm3099@pm.me>
392384f to
8192bef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Migrated the test
TestAPIStatsNoStreamConnectedContainerfrom theintegration-cli/directory to theintegration/directory in reference to epic #50159.- How I did it
Rewriting the test using the Go-client and moving it to the
integration/diectory- How to verify it
TESTDIRS='./integration/container/' TESTFLAGS='-test.run TestStatsNoStreamConnectedContainers' make test-integration- Human readable description for the release notes