migrate TestAPISwarmErrorHandling to Integration Test#51839
Open
2003Aditya wants to merge 1 commit intomoby:masterfrom
Open
migrate TestAPISwarmErrorHandling to Integration Test#518392003Aditya wants to merge 1 commit intomoby:masterfrom
2003Aditya wants to merge 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Aditya Mishra <mishraaditya675@gmail.com>
e906527 to
af7afcc
Compare
Contributor
|
The new test is failing ... The original test did this - so something similar probably needs to be carried over. It'd be worth looking in a bit more detail than I have at that function does, the migrated tests are likely to need something similar? ...
The test is renamed from (And, nit: blank line at the end of the test!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Migrated the
TestAPISwarmErrorHandlingtest fromintegration-cli/docker_api_swarm_test.goto the new integration test framework underintegration/service/swarm_test.go.