migrate TestAPISwarmCAHash to Integration Test#51837
Merged
robmry merged 1 commit intomoby:masterfrom Feb 15, 2026
Merged
Conversation
a4c21e4 to
05d1c78
Compare
Contributor
|
The new test is failing with this, all Swarm tests will need to be skipped for-now when the daemon's using nftables ... |
Contributor
|
Oh, I see - the test's starting two daemons ... but only one of them's started with NewSwarm - which adds an I think it'd be best to skip the test if the main daemon's using nftables. So, it'll be something like: |
39a154c to
8669d9c
Compare
robmry
reviewed
Feb 13, 2026
integration/service/swarm_test.go
Outdated
Comment on lines
+15
to
+16
| ctx := setupTest(t) | ||
| skip.If(t, strings.HasPrefix(testEnv.FirewallBackendDriver(), "nftables"), "swarm cannot be used with nftables") |
Contributor
There was a problem hiding this comment.
There's no need to setupTest if the test is going to be skipped - best to swap these lines?
Signed-off-by: Aditya Mishra <mishraaditya675@gmail.com>
8669d9c to
b7a404d
Compare
robmry
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Migrated the TestSwarmCAHash test from integration-cli/docker_api_swarm_test.go to the new integration test framework under integration/service/swarm_test.go.