Dockerfile: verify the git tags with the hashes#51626
Closed
AkihiroSuda wants to merge 1 commit intomoby:masterfrom
Closed
Dockerfile: verify the git tags with the hashes#51626AkihiroSuda wants to merge 1 commit intomoby:masterfrom
AkihiroSuda wants to merge 1 commit intomoby:masterfrom
Conversation
thaJeztah
reviewed
Dec 1, 2025
| @@ -1,10 +1,15 @@ | |||
| # syntax=docker/dockerfile:1 | |||
| # syntax=docker/dockerfile:1.20.0@sha256:26147acbda4f14c5add9946e2fd2ed543fc402884fd75146bd342a7f6271dc1d | |||
Member
There was a problem hiding this comment.
This defeats the purpose of using :1, which is on purpose a floating tag
Member
Author
There was a problem hiding this comment.
Can we reconsider using a floating tag?
A floating tag can be potentially replaced to a malicious frontend
Member
Author
There was a problem hiding this comment.
Maybe we should just remove the # syntax line?
Verify the tags of containerd*, runc, tini, and rootlesskit with their commit hashes for tolerance to compromise of the tags. These binaries are depeneded by docker-ce-packaging here: https://github.com/docker/docker-ce-packaging/blob/7e726fa319c261676d06b6ae10c04a3df80e4c48/static/Makefile#L43-L58 Replaces PR 49674 Unlike the previous PR, this commit does not need the `git-checkout-tag-with-hash.sh` helper script. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
a1c046a to
2e027a6
Compare
Member
Author
|
Will revisit after the release of |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Verify the tags of containerd*, runc, tini, and rootlesskit with their commit hashes for tolerance to compromise of the tags.
These binaries are depeneded by docker-ce-packaging here: https://github.com/docker/docker-ce-packaging/blob/7e726fa319c261676d06b6ae10c04a3df80e4c48/static/Makefile#L43-L58
Replaces:
Unlike the previous PR, this commit does not need the
git-checkout-tag-with-hash.shhelper script.- How I did it
By using
ADD ${URL}?tag=${TAG}&checksum=${COMMIT}.Available since Dockerfile v1.18: https://docs.docker.com/build/buildkit/dockerfile-release-notes/#1180
- How to verify it
makepassesmakefails after modifying some hash- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)