migrate TestAPIOptionsRoute to integration test#51585
Merged
robmry merged 1 commit intomoby:masterfrom Jan 7, 2026
Merged
Conversation
373aff9 to
ef8dde4
Compare
Contributor
|
Looks like this one needs a rebase. |
Contributor
|
I think we should just remove this test. It's more of a test against the gorilla/mux rather than our API. |
Contributor
Author
Contributor
|
Let's remove it - thank you. |
Signed-off-by: Aditya Mishra <mishraaditya675@gmail.com>
ef8dde4 to
93afda3
Compare
robmry
approved these changes
Jan 7, 2026
Contributor
|
Test failure is unrelated - let's merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Migrated the
TestAPIOptionsRoutetest fromintegration-cli/docker_api_test.goto the new integration test framework underintegration/system/api_test.go.