migrate TestAPIImagesSaveAndLoad to integration test#51559
Merged
robmry merged 1 commit intomoby:masterfrom Nov 26, 2025
Merged
migrate TestAPIImagesSaveAndLoad to integration test#51559robmry merged 1 commit intomoby:masterfrom
robmry merged 1 commit intomoby:masterfrom
Conversation
c915e15 to
b76ca27
Compare
robmry
reviewed
Nov 20, 2025
integration/image/save_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestAPIImageSaveAndLoad(t *testing.T) { |
Contributor
There was a problem hiding this comment.
I think this is covered by TestSaveAndLoadPlatform. We can probably just delete the integration-cli test, and not add this new test?
Signed-off-by: Aditya Mishra <mishraaditya675@gmail.com>
b76ca27 to
93825e0
Compare
robmry
approved these changes
Nov 26, 2025
Contributor
|
The Windows test failure is unrelated ... let's get this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration-climigration #50159- What I did
Migrated the
TestAPIImagesSaveAndLoadtest fromintegration-cli/docker_api_image_test.goto the new integration test framework underintegration/image/save_test.go.