integration: migrate TestAPIGetEnabledCORS to integration test#51550
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 18, 2025
Merged
integration: migrate TestAPIGetEnabledCORS to integration test#51550thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
reviewed
Nov 17, 2025
| assert.NilError(c, err) | ||
| assert.Equal(c, res.StatusCode, http.StatusOK) | ||
| body.Close() | ||
| // TODO: @runcom incomplete tests, why old integration tests had this headers |
Member
There was a problem hiding this comment.
Looking at the original test, I think all the relevant parts for the test itself were disabled, so effectively it wasn't testing anything really.
I think we should just remove the test and not migrate it
Member
There was a problem hiding this comment.
If you can update it to just remove the test, then we can merge it.
Signed-off-by: Aditya Mishra <mishraaditya675@gmail.com>
850908a to
9fbc9d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration-climigration #50159- What I did
Migrated the
TestAPIGetEnabledCORStest fromintegration-cli/docker_api_test.goto the new integration test framework underintegration/system/api_test.go.