client: refactor Events, Info, RegistryLogin#51320
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 29, 2025
Merged
Conversation
Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Austin Vazquez <austin.vazquez@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was referenced Oct 29, 2025
thaJeztah
commented
Oct 29, 2025
|
|
||
| // RegistryLoginResult holds the result of a RegistryLogin query. | ||
| type RegistryLoginResult struct { | ||
| Auth registry.AuthenticateOKBody |
Member
Author
There was a problem hiding this comment.
I'll open a follow-up PR to rename this type to something cleaner (AuthenticateResponse probably?)
thaJeztah
commented
Oct 29, 2025
Comment on lines
+27
to
+33
| auth := registry.AuthConfig{ | ||
| Username: options.Username, | ||
| Password: options.Password, | ||
| ServerAddress: options.ServerAddress, | ||
| IdentityToken: options.IdentityToken, | ||
| RegistryToken: options.RegistryToken, | ||
| } |
Member
Author
There was a problem hiding this comment.
@Benehiko wondering if you've had time to look if all of these fields should indeed be user-configurable as part of the request (mostly looking at IdentityToken and RegistryToken), or if one of them is only used internally (as part of the registry client round-trip)
vvoland
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiskUsage.*fields and add type specific fields #51235 (comment)- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)