client: refactor ContainerTop to wrap options and results#51313
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 29, 2025
Merged
client: refactor ContainerTop to wrap options and results#51313thaJeztah merged 1 commit intomoby:masterfrom
ContainerTop to wrap options and results#51313thaJeztah merged 1 commit intomoby:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ContainerTop client method to use structured options and results types instead of raw parameters and API response types, aligning with the pattern used by other container operations and decoupling the client interface from API implementation details.
- Introduces
ContainerTopOptionsstruct to wrap theargumentsparameter - Introduces
ContainerTopResultstruct to wrap the response data - Updates the
ContainerTopmethod signature and all call sites to use the new types
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/container_top.go | Defines new ContainerTopOptions and ContainerTopResult types and refactors ContainerTop to use them |
| client/client_interfaces.go | Updates the ContainerAPIClient interface signature for ContainerTop |
| integration-cli/docker_api_containers_test.go | Updates test calls to use the new ContainerTopOptions struct |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
c71e47d to
ec22a1e
Compare
thaJeztah
approved these changes
Oct 29, 2025
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
we really need to find a replacement for this command that's better than "shell out to ps and pass arbitrary args"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
#50965
This change refactors the client implementation of
ContainerTopto take client defined options and results to decouple future client development from API changes.- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)