client: remove NegotiateAPIVersion, NegotiateAPIVersionPing#51307
Merged
austinvazquez merged 1 commit intomoby:masterfrom Oct 28, 2025
Merged
client: remove NegotiateAPIVersion, NegotiateAPIVersionPing#51307austinvazquez merged 1 commit intomoby:masterfrom
austinvazquez merged 1 commit intomoby:masterfrom
Conversation
Remove these methods in favor of adding negotiation options to the Ping method. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
7 tasks
thaJeztah
commented
Oct 27, 2025
Comment on lines
261
to
-265
| func (cli *Client) checkVersion(ctx context.Context) error { | ||
| if !cli.manualOverride && cli.negotiateVersion && !cli.negotiated.Load() { | ||
| // Ensure exclusive write access to version and negotiated fields | ||
| cli.negotiateLock.Lock() | ||
| defer cli.negotiateLock.Unlock() |
Member
Author
There was a problem hiding this comment.
I have some follow-up changes to make to solidify some of the logic, but those should not introduce user-facing changes, so I'll work on those later.
thaJeztah
commented
Oct 27, 2025
Comment on lines
252
to
254
| func TestNegotiateAPIVersionEmpty(t *testing.T) { | ||
| t.Setenv("DOCKER_API_VERSION", "") | ||
|
|
Member
Author
There was a problem hiding this comment.
Various of these tests have some overlap as well (and some should likely be moved to client/ping_test.go, but also keeping that for a later exercise. 😅
austinvazquez
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove these methods in favor of adding negotiation options to the Ping method.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)