api/types/container: StatsResponse: add OSType field, remove client.ContainerStatsResult.OSType#51305
Merged
thaJeztah merged 2 commits intomoby:masterfrom Oct 27, 2025
Merged
Conversation
11f9840 to
ac2306b
Compare
Adds a per-stats OSType field to allow handle the platform-specific fields. Before this change, the client had to get the OSType field from the server's API response header and copy it to each record. Older daemon versions don't have this field, so the client still needs to handle fallbacks. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ac2306b to
150446c
Compare
The API now includes this information per record, and clients can get this information using the `Ping` method if needed as fallback. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
150446c to
c4aee2a
Compare
austinvazquez
approved these changes
Oct 27, 2025
robmry
approved these changes
Oct 27, 2025
| example: "boring_wozniak" | ||
| os_type: | ||
| description: | | ||
| OSType is the OS of the container ("linux" or "windows") to allow |
Contributor
There was a problem hiding this comment.
Could drop the "OSType is"? (Or call it "os_type"?)
Member
Author
There was a problem hiding this comment.
Ah, yeah, I stuck with the GoDoc format for these, with the anticipation that we may be generating these from swagger at some point 😅
But indeed for the Swagger probably doesn't make sense for this one. I'll leave it for a cleanup round after this 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api/types/container: StatsResponse: add OSType field
Adds a per-stats OSType field to allow handle the platform-specific fields.
Before this change, the client had to get the OSType field from the server's
API response header and copy it to each record.
Older daemon versions don't have this field, so the client still needs to
handle fallbacks.
client: remove ContainerStatsResult.OSType field
The API now includes this information per record, and clients can
get this information using the
Pingmethod if needed as fallback.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)